Skip to content

[NanoAOD, BTV] Finalize UParT branches for NanoV15#47228

Merged
cmsbuild merged 2 commits intocms-sw:masterfrom
nurfikri89:from1500pre2_UParT_nanobranch
Jan 31, 2025
Merged

[NanoAOD, BTV] Finalize UParT branches for NanoV15#47228
cmsbuild merged 2 commits intocms-sw:masterfrom
nurfikri89:from1500pre2_UParT_nanobranch

Conversation

@nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Jan 31, 2025

PR description:

This PR finalizes the UParT branches for NanoAODv15.

  • Added probb and probbb. All the ingredients are now available to deduce the UParT raw scores.
  • Increase precision of UParT tagging branches from 10 to 12, for more stable re-calculation of UParT raw scores.
  • Fix documentation for UParTAK4RegPtRawCorrNeutrino branch

PR validation:

  • Estimated event size increase is by 1.5% with a TTto4Q MC sample.
  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos with the exception of a few workflows which failed because of missing relval input files.
  • passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Jan 31, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47228/43508

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2025

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Jan 31, 2025

enable nano

@hqucms
Copy link
Contributor

hqucms commented Jan 31, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2025

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a971e/44110/summary.html
COMMIT: 12791c9
CMSSW: CMSSW_15_0_X_2025-01-31-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47228/44110/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 84 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016770
  • DQMHistoTests: Total failures: 120
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016630
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 22.379000000000005 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.331 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.800 KiB Physics/NanoAODDQM
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1026 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 56 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 75127
  • DQMHistoTests: Total failures: 28
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 75099
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 12.255000000000003 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 1.331 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.800 KiB Physics/NanoAODDQM
  • Checked 106 log files, 61 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.114 3.114 0.000 ( +0.0% ) 6.45 6.41 +0.6% 2.547 2.561
2500.002 3.230 3.230 0.000 ( +0.0% ) 5.76 5.72 +0.6% 2.985 2.994
2500.003 3.171 3.171 0.000 ( +0.0% ) 5.98 5.97 +0.1% 2.971 2.984
2500.011 1.644 1.644 0.000 ( +0.0% ) 10.26 10.22 +0.4% 2.633 2.643
2500.012 2.184 2.184 0.000 ( +0.0% ) 6.00 5.99 +0.2% 2.817 2.833
2500.013 2.000 2.000 0.000 ( +0.0% ) 8.44 8.43 +0.1% 2.734 2.735
2500.021 0.022 0.022 0.000 ( +0.0% ) 2.04 2.08 -2.0% 2.599 2.610
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.98 1.98 +0.1% 2.605 2.612
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.91 1.89 +1.0% 2.477 2.479
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.58 1.55 +2.0% 2.708 2.702
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.78 1.76 +1.4% 2.653 2.662
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.81 1.81 +0.1% 2.624 2.637
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.70 1.70 +0.2% 2.704 2.704
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.72 1.72 -0.0% 2.682 2.694
2500.101 2.847 2.844 0.002 ( +0.1% ) 16.61 16.38 +1.4% 2.646 2.652
2500.111 1.465 1.463 0.002 ( +0.2% ) 31.43 31.53 -0.3% 2.341 2.344
2500.112 1.885 1.883 0.002 ( +0.1% ) 25.79 25.68 +0.4% 2.409 2.417
2500.131 0.750 0.750 0.000 ( +0.0% ) 38.17 37.57 +1.6% 1.504 1.509
2500.201 2.676 2.674 0.002 ( +0.1% ) 13.83 13.69 +1.0% 2.218 2.219
2500.211 1.833 1.806 0.027 ( +1.5% ) 27.94 27.34 +2.2% 2.403 2.415
2500.212 2.229 2.203 0.027 ( +1.2% ) 22.78 22.42 +1.6% 2.494 2.498
2500.221 2.038 2.038 0.000 ( +0.0% ) 14.33 14.50 -1.2% 2.127 2.129
2500.222 3.482 3.479 0.003 ( +0.1% ) 13.42 13.21 +1.6% 2.221 2.228
2500.223 9.493 9.444 0.049 ( +0.5% ) 4.30 4.29 +0.2% 2.291 2.306
2500.224 6.547 6.480 0.067 ( +1.0% ) 1.41 1.41 +0.2% 2.284 2.299
2500.225 6.594 6.527 0.067 ( +1.0% ) 1.31 1.31 +0.2% 2.512 2.507
2500.226 3.175 3.172 0.003 ( +0.1% ) 13.68 13.67 +0.1% 2.215 2.222
2500.227 1.442 1.442 0.000 ( +0.0% ) 24.12 23.89 +0.9% 1.443 1.457
2500.228 3.959 3.957 0.002 ( +0.0% ) 9.23 9.17 +0.7% 2.315 2.320
2500.231 1.457 1.457 0.000 ( +0.0% ) 23.10 22.92 +0.8% 2.298 2.299
2500.232 2.489 2.462 0.027 ( +1.1% ) 21.29 21.06 +1.1% 2.400 2.404
2500.233 4.988 4.954 0.034 ( +0.7% ) 6.26 6.24 +0.4% 2.465 2.487
2500.234 3.884 3.844 0.040 ( +1.0% ) 1.81 1.80 +0.7% 2.421 2.443
2500.235 3.916 3.876 0.040 ( +1.0% ) 1.69 1.68 +0.5% 2.636 2.641
2500.236 2.278 2.252 0.027 ( +1.2% ) 22.37 22.54 -0.7% 2.394 2.393
2500.237 1.018 1.018 0.000 ( +0.0% ) 35.72 35.55 +0.5% 1.450 1.468
2500.238 2.466 2.444 0.022 ( +0.9% ) 17.64 17.59 +0.3% 2.484 2.494
2500.241 9.404 9.404 0.000 ( +0.0% ) 7.62 7.43 +2.6% 1.926 1.932
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.64 1.67 -1.6% 1.728 1.730
2500.243 2.712 2.712 0.000 ( +0.0% ) 15.72 14.95 +5.1% 1.059 1.070
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.15 1.15 +0.6% 1.698 1.720
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.55 1.55 +0.1% 1.670 1.689
2500.251 645.314 645.314 0.000 ( +0.0% ) 1.67 1.69 -0.9% 1.790 1.790
2500.901 1.819 1.819 0.000 ( +0.0% ) 47.28 46.34 +2.0% 1.447 1.454
2500.902 1.665 1.665 0.000 ( +0.0% ) 49.90 47.90 +4.2% 1.337 1.346
2500.911 14.345 14.345 0.000 ( +0.0% ) 8.15 9.29 -12.3% 1.088 1.100
2500.912 0.199 0.240 -0.041 ( -16.9% ) 2.83 3.01 -5.8% 0.849 0.853
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.64 2.60 +1.6% 0.852 0.859

@hqucms
Copy link
Contributor

hqucms commented Jan 31, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Jan 31, 2025

+1

@cmsbuild cmsbuild merged commit a580b3b into cms-sw:master Jan 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code-checks-approved fully-signed orp-approved tests-approved xpog-approved

Projects

None yet

Milestone

CMSSW_15_0_X

Development

Successfully merging this pull request may close these issues.

4 participants

@nurfikri89 @cmsbuild @hqucms @mandrenguyen